Updates sample scripts to align with v10. Closes #6369 #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanholemans
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Splendid work @Adam-it. While rechecking I found a few things that we should fix IMO.
- I noticed we're using some
spo site removecommands without--forceflag. - I found one occurrence where we use
spo folder copywith--allowSchemaMismatch. This option doesn't exist anymore. - For all scripts where we changed something, we should update the metadata version to
10.0.0.
docs/docs/sample-scripts/entra/replace-owner-with-a-different-one/index.mdx
Show resolved
Hide resolved
|
@milanholemans thanks for the review feed. Ready for another round? |
milanholemans
approved these changes
Nov 23, 2024
docs/docs/sample-scripts/entra/bulk-manage-group-users/assets/sample.json
Show resolved
Hide resolved
docs/docs/sample-scripts/entra/replace-membership-of-selected-groups/assets/sample.json
Show resolved
Hide resolved
docs/docs/sample-scripts/entra/replace-owner-with-a-different-one/assets/sample.json
Show resolved
Hide resolved
docs/docs/sample-scripts/spo/copy-library-folders-and-contents-to-another-library/index.mdx
Show resolved
Hide resolved
Good feed, I will try to do a fixup today at night |
@milanholemans all rechecked and done |
|
Merged manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6369